Skip to content

Comments

miner: get rid of test_backend helper functions#1424

Merged
manav2401 merged 10 commits intodevelopfrom
manav/refactor-miner-tests
Jan 30, 2025
Merged

miner: get rid of test_backend helper functions#1424
manav2401 merged 10 commits intodevelopfrom
manav/refactor-miner-tests

Conversation

@manav2401
Copy link
Member

Description

Closes #1421

This PR tries to remove the miner/test_backend.go file completely which was used for miner tests. It had duplicate functions with very little change from actual miner functions which increases work when we have to refactor anything. This PR tries to generalise the actual functions such that they can be used directly in tests.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 changed the title miner, core: get rid of test_backend helper functions miner: get rid of test_backend helper functions Jan 28, 2025
Base automatically changed from manav/remove-tracing-from-miner to develop January 30, 2025 16:57
@manav2401 manav2401 merged commit a2f5455 into develop Jan 30, 2025
8 checks passed
@manav2401 manav2401 deleted the manav/refactor-miner-tests branch January 30, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants