Conversation
ssandeep
approved these changes
Jan 29, 2025
pratikspatil024
approved these changes
Jan 29, 2025
cffls
reviewed
Jan 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1425 +/- ##
===========================================
+ Coverage 50.30% 50.34% +0.03%
===========================================
Files 769 771 +2
Lines 125643 125779 +136
===========================================
+ Hits 63209 63322 +113
- Misses 58398 58408 +10
- Partials 4036 4049 +13 ☔ View full report in Codecov by Sentry. |
cffls
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--parallelevm.enforceflag to force bor to only execute blocks in parallel and don't use serial execution at all. This can be used to test the block-stm implementation for every block (as compared to some blocks currently).Original plan was to maintain this branch separately but maybe it's worth merging this as we can use this internally on devnodes as well instead of keeping this branch up to date.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it