You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the method handler crash issue when calling eth_simulateV1 method.
Changes
Bugfix (non-breaking change that solves an issue)
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
I have added at least 2 reviewer or the whole pos-v1 team
I have added sufficient documentation in code
I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
Includes RPC methods changes, and the Notion documentation has been updated
Cross repository changes
This PR requires changes to heimdall
In case link the PR here:
This PR requires changes to matic-cli
In case link the PR here:
Testing
I have added unit tests
I have added tests to CI
I have tested this code manually on local environment
I have tested this code manually on remote devnet using express-cli
I have tested this code manually on amoy
I have created new e2e tests into express-cli
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
issue of the eth_simulateV1 is casued by BlobScheduleConfig being nil during calling to CalcBlobFee on Bor chains. After resolving this issue. Calling eth_simulateV1 result in "unexpected withdrawals" error, which indicate withdrawals are not supported in the block body. Then, this issue is resolved by setting it to Nil for bor chain. Finally, functions SetStateSync and SubscribeStateSyncEvent are added to simChainHeadReader so that it implements core.BorStateSyncer
hello @kamuikatsurgi , since v2.5.6 release have been made and the target branch of the merge request is v2.5.6-candidate, should I recreate this merge request towards some other branch?
hello @kamuikatsurgi , since v2.5.6 release have been made and the target branch of the merge request is v2.5.6-candidate, should I recreate this merge request towards some other branch?
Hey @ChanHongMing, could you please change the base branch to 'develop' and also pull the latest changes from the 'develop' branch? We will get reviews on this soon and get merged. Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChanHongMing
changed the title
Description
Fixing the method handler crash issue when calling eth_simulateV1 method.
Changes
Bugfix (non-breaking change that solves an issue)
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
issue of the eth_simulateV1 is casued by BlobScheduleConfig being nil during calling to CalcBlobFee on Bor chains. After resolving this issue. Calling eth_simulateV1 result in "unexpected withdrawals" error, which indicate withdrawals are not supported in the block body. Then, this issue is resolved by setting it to Nil for bor chain. Finally, functions SetStateSync and SubscribeStateSyncEvent are added to simChainHeadReader so that it implements core.BorStateSyncer