Skip to content

Comments

feat: add network diagnostics and state dump action#2051

Merged
kamuikatsurgi merged 2 commits intodevelopfrom
kamui/add-network-diagnostics-and-state-dump-action
Feb 11, 2026
Merged

feat: add network diagnostics and state dump action#2051
kamuikatsurgi merged 2 commits intodevelopfrom
kamui/add-network-diagnostics-and-state-dump-action

Conversation

@kamuikatsurgi
Copy link
Member

Description

Adds the reusable network diagnostics and state dump action from the pos-workflows repo.

@claude
Copy link

claude bot commented Feb 11, 2026

Code Review

Issue Found

File: .github/workflows/kurtosis-e2e.yml (line 156)

Problem: Debug/test code left in. The exit 1 on line 156 will cause the RPC tests step to always fail immediately without running any actual tests.

      - name: Run RPC tests
        id: rpc-tests
        working-directory: pos-workflows/tests/rpc_tests
        run: |
          exit 1  # <-- Remove this line
          export RPC_URL=$(kurtosis port print ${{ env.ENCLAVE_NAME }} l2-el-1-bor-heimdall-v2-validator rpc)

Impact: This will break the CI pipeline by causing all builds to fail at the RPC tests step without actually running any tests. The new diagnostics collection action will trigger on every run.

Suggested Fix: Remove the exit 1 line before merging.


Checked for bugs and CLAUDE.md compliance.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.17%. Comparing base (96df644) to head (c955f13).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2051      +/-   ##
===========================================
+ Coverage    50.15%   50.17%   +0.02%     
===========================================
  Files          871      871              
  Lines       150614   150614              
===========================================
+ Hits         75546    75578      +32     
+ Misses       70023    69992      -31     
+ Partials      5045     5044       -1     

see 16 files with indirect coverage changes
see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@kamuikatsurgi kamuikatsurgi merged commit 94da0a6 into develop Feb 11, 2026
20 of 21 checks passed
@kamuikatsurgi kamuikatsurgi deleted the kamui/add-network-diagnostics-and-state-dump-action branch February 11, 2026 08:59
kamuikatsurgi added a commit that referenced this pull request Feb 13, 2026
* feat: add network diagnostics and state dump action

* remove: exit 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants