polygon/sync: announce blocks/hashes for blocks received via hash announcements#39
Closed
polygon/sync: announce blocks/hashes for blocks received via hash announcements#39
Conversation
kamuikatsurgi
approved these changes
Oct 14, 2025
marcello33
approved these changes
Oct 14, 2025
|
Should we also open a PR to upstream Erigon repo? |
Member
Author
We can but this only applies to polygon's sync logic so not sure how relevant it would be. |
Member
Author
|
Closing in favour of #44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sync issue was recently discovered on a devnet where a bor node was unable to sync with only erigon nodes as it's peers. On further debugging, it turns out that erigon in some cases doesn't announce new blocks or block hashes.
When processing a block, the source of that block is also passed along. If the source is
EventSourceP2PNewBlocki.e. block received directly via p2p, that block was further announced (normal block announcement to sqrt(peers) and hash announcement to all peers later). But if erigon receives an announcement of a new block hash (instead of full block), it marks the source asEventSourceP2PNewBlockHashes, fetches the block and processes it. Blocks from this source aren't propagated further which seems incorrect.This PR fixes that and also sends the block further to peers. This changes was tested on the devnet and it fixed the syncing issue for bor (with only erigon peers).