state-sync handling and receipts in eth/69#41
Merged
marcello33 merged 21 commits intorelease/3.2from Oct 27, 2025
Merged
Conversation
chore: add TD to StatusPacket69 for eth handshake
* fix: state sync receipts over P2P * chore: nit
There was a problem hiding this comment.
Pull Request Overview
This PR implements state-sync data handling in the eth/69 protocol, allowing nodes to send and persist state-sync transaction receipts. The changes align with Bor's PIP-74 state-sync receipt handling and remove the test-release CI step that depends on a private Erigon QA repository.
Key changes include:
- Integration of BorGenerator for state-sync receipt handling in the receipts.Generator
- Addition of state-sync receipt support in eth/69 protocol with TD field in StatusPacket69
- Removal of test-release CI workflow step and temporary disabling of QA RPC integration tests
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rpc/jsonrpc/receipts/receipts_generator.go | Added borGenerator field and state-sync receipt extraction logic to handle PIP-74 receipts |
| rpc/jsonrpc/receipts/handler_test.go | Added comprehensive test coverage for state-sync receipt reading scenarios |
| rpc/jsonrpc/receipts/bor_receipts_generator.go | Added bridgeReader interface and field to BorGenerator for accessing state-sync events |
| rpc/jsonrpc/eth_receipts.go | Updated GetBlockReceipts to handle state-sync receipts with special TransactionIndex |
| rpc/jsonrpc/eth_api.go | Modified to create and pass borReceiptGenerator to receipts.Generator |
| p2p/sentry/sentry_multi_client/sentry_multi_client.go | Added bridgeReader parameter for P2P state-sync receipt support |
| p2p/sentry/eth_handshake.go | Added TD field to eth/69 StatusPacket69 handshake |
| p2p/protocols/eth/protocol.go | Added TD field to StatusPacket69 structure |
| node/nodecfg/defaults.go | Changed default protocol version priority to eth/69 first |
| execution/types/receipt.go | Modified EncodeRLP69 to handle state-sync receipt type detection |
| execution/stages/mock/mock_sentry.go | Updated mock to pass nil bridgeReader parameter |
| execution/stages/blockchain_test.go | Formatting fix for TestReorgShortBlocks function |
| eth/backend.go | Added bridgeReaderForP2P initialization for P2P state-sync receipt serving |
| core/blockchain.go | Added PIP-74 comment for state-sync receipt handling |
| cmd/integration/commands/stages.go | Updated NewMultiClient call with nil bridgeReader |
| .github/workflows/release.yml | Removed test-release job and updated dependencies |
| .github/workflows/qa-rpc-integration-tests.yml | Temporarily disabled mainnet RPC integration tests |
| .github/workflows/qa-rpc-integration-tests-polygon.yml | Temporarily disabled polygon RPC integration tests |
| .github/workflows/qa-rpc-integration-tests-gnosis.yml | Temporarily disabled gnosis RPC integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kamuikatsurgi
approved these changes
Oct 27, 2025
* chore: Merge 'release/3.2' branch into mardizzone/ssTxs-eht69-3.2 * chore: some hf checks
kamuikatsurgi
approved these changes
Oct 27, 2025
Raneet10
approved these changes
Oct 27, 2025
kamuikatsurgi
pushed a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we implement the state-sync data handling in the new eth/69 protocol introduced by geth.
Now, nodes have the ability to send state-sync transaction receipts in eth/69 protocol, allowing them to persist the state-sync transaction receipts.
This PR reflects the Erigon's changes for this PR in bor:
Additionally, the test-release step in the CI workflow has been removed because it depends on private Erigon QA repo.