add base fee chart, safe and finalized blocks to monitor#589
Merged
Conversation
… finalized blocks to header
There was a problem hiding this comment.
Pull Request Overview
This PR updates the monitoring UI to support EIP-1559 by replacing the gas price chart with a base fee chart and displaying safe and finalized block numbers in the header.
- Replaces gas price chart with base fee chart for EIP-1559 networks.
- Adds safe and finalized block numbers to the header.
- Updates the UI and monitor logic to handle the new fields and reorganizes header layout.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| metrics/metrics.go | Adds GetMeanBaseFeePerBlock function for calculating base fees. |
| cmd/monitor/ui/ui.go | Updates GetCurrentText and SetUISkeleton to display safe/finalized blocks and adjust chart title based on EIP-1559 support. |
| cmd/monitor/monitor.go | Fetches safe and finalized block headers; integrates EIP-1559 support into monitor logic. |
Comments suppressed due to low confidence (1)
metrics/metrics.go:116
- [nitpick] Consider renaming the variable 'fee' to 'baseFees' for improved clarity in representing the base fee values.
fee := make([]float64, 0, len(bs))
praetoriansentry
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/0xPolygon/devtools/issues/200