Skip to content

Comments

chore!: loadtest clean-up#658

Merged
tclemos merged 24 commits intomainfrom
thiag/cleanup
Aug 11, 2025
Merged

chore!: loadtest clean-up#658
tclemos merged 24 commits intomainfrom
thiag/cleanup

Conversation

@tclemos
Copy link
Contributor

@tclemos tclemos commented Jul 30, 2025

closes https://github.com/0xPolygon/devtools/issues/355

Description

Remove modes:

  • call
  • function
  • random-precompile
  • specific-precompile

Flags renamed:

  • --lt-address to --loadtest-contract-address
  • -b, --byte-count to --store-data-size
  • --steady-state-tx-pool-size to --adaptive-target-size
  • --send-only to --fire-and-forget (--send-only alias was created to allow backward-compatibility)
  • --call-only to --eth-call-only
  • --to-random to --random-recipients
  • --sending-address-count to sending-accounts-count
  • --address-funding-amount to account-funding-amount
  • --pre-fund-sending-addresses to pre-fund-sending-accounts
  • --sending-addresses-file to sending-accounts-file

Flags removed:

  • -i, --iterations
  • --force-contract-deploy

Features affected:

  • If a mode requires an SC to work, the SC will be deployed automatically without requiring a flag to force it, or it will skip the deploy in case the address is provided via a flag. This applies to the modes: Increment, Random, Store, ERC20, and ERC721.

@tclemos tclemos self-assigned this Jul 30, 2025

This comment was marked as outdated.

@tclemos tclemos marked this pull request as ready for review August 1, 2025 12:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a significant cleanup of the loadtest command by removing deprecated modes and renaming flags for better clarity and consistency.

  • Removes 4 deprecated loadtest modes: call, function, random-precompile, and specific-precompile
  • Renames multiple flags for improved clarity (e.g., --lt-address to --loadtest-contract-address)
  • Simplifies contract deployment logic by automatically deploying smart contracts when required by specific modes

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
doc/polycli_loadtest_uniswapv3.md Updates flag documentation with renamed flags and removes deprecated options
doc/polycli_loadtest.md Updates comprehensive loadtest documentation removing deprecated modes and flags
doc/load-testing-guide.md Updates multi-account configuration documentation with renamed flags
cmd/monitorv2/renderer/tview_renderer.go Minor formatting cleanup (removes empty line)
cmd/loadtest/loadtestmode_string.go Updates generated string constants for removed loadtest modes
cmd/loadtest/loadtestUsage.md Updates usage documentation removing deprecated examples and modes
cmd/loadtest/loadtest.go Main implementation changes removing mode handlers and updating flag references
cmd/loadtest/app.go Updates flag definitions and variable names for renamed flags
cmd/loadtest/account.go Updates log messages to use "account" instead of "address" terminology
cmd/flag_loader/flag_loader.go Minor import reordering

@minhd-vu minhd-vu changed the title loadtest clean-up chore!: loadtest clean-up Aug 4, 2025
ARR552
ARR552 previously approved these changes Aug 4, 2025
Copy link
Contributor

@ARR552 ARR552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@minhd-vu minhd-vu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits: your choice if you want to address them

leovct
leovct previously approved these changes Aug 7, 2025
@tclemos tclemos merged commit 2b5ea3a into main Aug 11, 2025
14 checks passed
@tclemos tclemos deleted the thiag/cleanup branch August 11, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants