Merged
Conversation
…gic); rename --keep-funded-amount to --keep-funds-after-test
praetoriansentry
previously approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR performs a significant cleanup of the loadtest command by removing deprecated modes and renaming flags for better clarity and consistency.
- Removes 4 deprecated loadtest modes:
call,function,random-precompile, andspecific-precompile - Renames multiple flags for improved clarity (e.g.,
--lt-addressto--loadtest-contract-address) - Simplifies contract deployment logic by automatically deploying smart contracts when required by specific modes
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/polycli_loadtest_uniswapv3.md | Updates flag documentation with renamed flags and removes deprecated options |
| doc/polycli_loadtest.md | Updates comprehensive loadtest documentation removing deprecated modes and flags |
| doc/load-testing-guide.md | Updates multi-account configuration documentation with renamed flags |
| cmd/monitorv2/renderer/tview_renderer.go | Minor formatting cleanup (removes empty line) |
| cmd/loadtest/loadtestmode_string.go | Updates generated string constants for removed loadtest modes |
| cmd/loadtest/loadtestUsage.md | Updates usage documentation removing deprecated examples and modes |
| cmd/loadtest/loadtest.go | Main implementation changes removing mode handlers and updating flag references |
| cmd/loadtest/app.go | Updates flag definitions and variable names for renamed flags |
| cmd/loadtest/account.go | Updates log messages to use "account" instead of "address" terminology |
| cmd/flag_loader/flag_loader.go | Minor import reordering |
minhd-vu
reviewed
Aug 4, 2025
Contributor
minhd-vu
left a comment
There was a problem hiding this comment.
some nits: your choice if you want to address them
minhd-vu
reviewed
Aug 5, 2025
leovct
previously approved these changes
Aug 7, 2025
praetoriansentry
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/0xPolygon/devtools/issues/355
Description
Remove modes:
callfunctionrandom-precompilespecific-precompileFlags renamed:
--lt-addressto--loadtest-contract-address-b, --byte-countto--store-data-size--steady-state-tx-pool-sizeto--adaptive-target-size--send-onlyto--fire-and-forget(--send-onlyalias was created to allow backward-compatibility)--call-onlyto--eth-call-only--to-randomto--random-recipients--sending-address-counttosending-accounts-count--address-funding-amounttoaccount-funding-amount--pre-fund-sending-addressestopre-fund-sending-accounts--sending-addresses-filetosending-accounts-fileFlags removed:
-i, --iterations--force-contract-deployFeatures affected:
Increment,Random,Store,ERC20, andERC721.