feat: add flag --wait-for-receipt to loadtest#665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/0xPolygon/devtools/issues/352
✅ Task Implementation Summary:
--wait-for-receiptFlagBackground
Successfully implemented an opt-in
--wait-for-receiptflag that forces each goroutine to wait for transaction receipts before proceeding, preventing orphaned transactions andnonce gaps on unreliable RPC endpoints.
🎯 Goals Achieved
✅ Opt-in Receipt Waiting
--wait-for-receiptflag (defaults to false)✅ Universal Mode Support
✅ Configurable Retry Logic
✅ Exponential Backoff with Jitter
✅ Updated Documentation
🏗️ Implementation Details
Clean API Design
Created multiple convenience functions for different use cases:
Robust Edge Case Handling
Integration Points
✅ Acceptance Criteria Verification
--wait-for-receiptflag implemented🚀 Usage Examples
Basic Receipt Waiting
polycli loadtest
--wait-for-receipt--mode transaction --requests 100Custom Retry Configuration
polycli loadtest
--wait-for-receipt--receipt-retry-max 50
--receipt-retry-initial-delay-ms 200
--mode erc20 --requests 1000
Infinite Retries Until Timeout
polycli loadtest
--wait-for-receipt--receipt-retry-max 0
--mode deploy --requests 10
🎉 Benefits
📋 Testing Verified
Status: ✅ COMPLETE - All requirements fulfilled, ready for deployment