Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where hints might not be properly resumed in the recover_signer_unchecked function when early returns occur. The fix implements an RAII (Resource Acquisition Is Initialization) guard pattern that ensures resume_hints() is always called via the Drop trait, even when the function exits early through multiple potential error paths.
Changes:
- Introduced a
ResumeHintsGuardstruct with a Drop implementation to ensure hints are resumed on all code paths - Replaced manual cleanup code with RAII pattern in
recover_signer_unchecked - Updated zisk-related dependencies to commit
acaaf0476a06f442a042d21fc3f41b27d03e703dand addedlib-floatdependency
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/crypto/src/lib.rs | Implements RAII guard to ensure hints are resumed on early returns in recover_signer_unchecked |
| bin/guest/Cargo.lock | Updates zisk dependencies to a specific commit and adds lib-float dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.