Skip to content

Comments

Fix resume hints#39

Open
agnusmor wants to merge 1 commit intomain-rethfrom
fix-resume
Open

Fix resume hints#39
agnusmor wants to merge 1 commit intomain-rethfrom
fix-resume

Conversation

@agnusmor
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where hints might not be properly resumed in the recover_signer_unchecked function when early returns occur. The fix implements an RAII (Resource Acquisition Is Initialization) guard pattern that ensures resume_hints() is always called via the Drop trait, even when the function exits early through multiple potential error paths.

Changes:

  • Introduced a ResumeHintsGuard struct with a Drop implementation to ensure hints are resumed on all code paths
  • Replaced manual cleanup code with RAII pattern in recover_signer_unchecked
  • Updated zisk-related dependencies to commit acaaf0476a06f442a042d21fc3f41b27d03e703d and added lib-float dependency

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
crates/crypto/src/lib.rs Implements RAII guard to ensure hints are resumed on early returns in recover_signer_unchecked
bin/guest/Cargo.lock Updates zisk dependencies to a specific commit and adds lib-float dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agnusmor agnusmor self-assigned this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant