Added serialization support for compatibility with latest plonky2 head#3
Open
cf wants to merge 2 commits into0xPolygonZero:mainfrom
Open
Added serialization support for compatibility with latest plonky2 head#3cf wants to merge 2 commits into0xPolygonZero:mainfrom
cf wants to merge 2 commits into0xPolygonZero:mainfrom
Conversation
|
This is great and much appreciated ! It would be great to have this one get in ! @dlubarov, @npwardberkeley |
Contributor
npwardberkeley
left a comment
npwardberkeley
left a comment
There was a problem hiding this comment.
Looks good for the most part!
| pub fn get_limb(&self, i: usize) -> U32Target { | ||
| self.limbs[i] | ||
| } | ||
| pub fn write_to_serializer(&self, dst: &mut Vec<u8>) -> IoResult<()> { |
Contributor
There was a problem hiding this comment.
nit: spacing between functions
| plonky2 = { version = "0.1.2", default-features = false } | ||
| plonky2_u32 = { version = "0.1.0", default-features = false } | ||
| plonky2 = { git = "https://github.com/mir-protocol/plonky2", rev = "3de92d9ed1721cec133e4e1e1b3ec7facb756ccf", default-features = false } | ||
| plonky2_u32 = { git = "https://github.com/cf/plonky2-u32", rev = "5b3cb748be32844ae449c62eae6f08278e4b4911", default-features = false } |
Contributor
There was a problem hiding this comment.
For all of these (especially your forked repo here), is there a reason for using these specific commits?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added serialization support for generators which implement SimpleGenerator (required to use this package with the latest plonky2:HEAD):