EulerSwap solvency check - #372
Merged
Merged
Conversation
e1Ru1o
force-pushed
the
e1Ru1o/eulerswap-insolvency-check
branch
from
July 21, 2025 11:13
a8eece9 to
22e3117
Compare
duncancmt
reviewed
Jul 22, 2025
duncancmt
left a comment
duncancmt
left a comment
Collaborator
There was a problem hiding this comment.
Tests look good, but I am concerned that they still passed given the confusion between units of underlying and of vault shares. Before fixing that, please add a unit test that fails due to this confusion and then demonstrate that the new test passes after the bug is fixed
e1Ru1o
commented
Jul 24, 2025
| (, debt) = oracle.fastGetQuotes(debt, debtVault.fastAsset(), unitOfAccount); | ||
| // multiply by 1e4 to avoid divisions when adjusting LTVBorrow bps of collaterals. | ||
| // All amounts in EulerSwap are lower than uint112 so there should not be overflow errors. | ||
| // Debt is not LTV adjusted. LTV is in basis points. By multiplying the debt bt 10_000, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.