This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Open
Conversation
Contributor
|
@tiennampham23 Thank you for your contribution! Could you provide some context behind this change? |
Author
|
@eitu5ami I apologize for missing the description earlier. The buffer pool is used to prevent the allocation of a large number of byte slices when uploading a significant amount of data. We utilize the allocated buffer pool to store the response bytes. If we do not use the buffer pool, the reserve proxy will allocate the byte slices with every request, and the garbage collection will clear it afterward. As the number of requests increases, the memory usage will peak at the time the garbage collector is running. As the documentation // BufferPool optionally specifies a buffer pool to
// get byte slices for use by io.CopyBuffer when
// copying HTTP response bodies.
BufferPool BufferPool
if p.BufferPool != nil {
buf = p.BufferPool.Get()
defer p.BufferPool.Put(buf)
} |
Contributor
|
@tiennampham23 I will work on it once I merge a few of our outstanding changes. I will keep you posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.