Open
Conversation
c-cube
reviewed
Mar 6, 2026
Collaborator
c-cube
left a comment
c-cube
left a comment
There was a problem hiding this comment.
Very minor changes but this is looking good! :)
| let command = List.concat [base_command; args] in | ||
| send_request connection command >>= return_ok_or_nil | ||
| if keepttl && (ex > 0 || px > 0) then | ||
| IO.fail (Invalid_argument "SET command cannot combine KEEPTTL with EX or PX options.") |
Collaborator
There was a problem hiding this comment.
Suggested change
| IO.fail (Invalid_argument "SET command cannot combine KEEPTTL with EX or PX options.") | |
| IO.fail (Invalid_argument "Redis.set: command cannot combine KEEPTTL with EX or PX options.") |
| | false -> [] | ||
| | true -> ["KEEPTTL"] in | ||
| let base_command = [ "SET"; key; value; ] in | ||
| let args = List.concat [ex; px; nx; xx; keepttl] in |
Collaborator
There was a problem hiding this comment.
maybe we can have only one List.concat here? :)
|
|
||
| (** Set key to hold the string value. *) | ||
| (** Set key to hold the string value. | ||
| @param keepttl retain the existing TTL on the key (since Redis 6.0). *) |
Collaborator
There was a problem hiding this comment.
also a @since for the library version, please!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for
keepttloption in sethttps://redis.io/docs/latest/commands/set/