fix: await onVaultUpdate to prevent save interruption on popup close#4
Merged
0xneves merged 1 commit intorefactor/visualfrom Feb 6, 2026
Merged
fix: await onVaultUpdate to prevent save interruption on popup close#40xneves merged 1 commit intorefactor/visualfrom
0xneves merged 1 commit intorefactor/visualfrom
Conversation
The bug was that contacts (and potentially groups/identities) were being lost when the extension popup was closed quickly after adding them. Root cause: onVaultUpdate() was not awaited, so the UI would show success and allow the popup to close before saveVault() completed. When the popup closes, its JS context is destroyed, potentially interrupting the save. Fixed all occurrences in: - DashboardScreen.tsx (6 places) - ConnectFlowScreen.tsx (3 places) - OnboardingScreen.tsx (1 place) Now the UI waits for the save to complete before closing modals/showing success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was that contacts (and potentially groups/identities) were being lost when the extension popup was closed quickly after adding them.
Root cause: onVaultUpdate() was not awaited, so the UI would show success and allow the popup to close before saveVault() completed. When the popup closes, its JS context is destroyed, potentially interrupting the save.
Fixed all occurrences in:
Now the UI waits for the save to complete before closing modals/showing success.