Round the timestamp value down #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since in JavaScript timestamps are done in MS, this dividing by 1000 produces a number with a decimal. By flooring it, we produce a consistent number that matches how other langauges generate timestamps.
Owner
|
Won't the date object be different if we convert it back to a javascript date object? |
Author
|
Technically yes, because we're dropping the milliseconds, but the date isn't presented anywhere showing milliseconds so I don't think it's an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in JavaScript timestamps are done in MS, this dividing by 1000
produces a number with a decimal. By flooring it, we produce
a consistent number that matches how other langauges generate
timestamps.
I encountered this issue when creating my own blockchain implementation in Ruby, and noticing the hash didn't match when I put in the same inputs. It turned out that since this was using decimals for the timestamp it didn't match. This resolves it.
Also, there are many tests failing on master right now, so I was unable to write one for this or make sure this didn't break more.