Skip to content

Parse projectId from AccessKey, add it to log attrs & telemetry #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VojtechVitek merged 1 commit into from
Jul 2, 2025
Merged

Parse projectId from AccessKey, add it to log attrs & telemetry #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,10 @@ func Session(cfg Options) func(next http.Handler) http.Handler {
sessionType = max(sessionType, proto.SessionType_AccessKey)

ctx = WithAccessKey(ctx, accessKey)
// TODO:
// projectID, _ = proto.GetProjectID(accessKey)
// ctx = withProjectIDy(ctx, projectID)
// httplog.SetAttrs(ctx, slog.Uint64("projectId", projectID))

projectID, _ = GetProjectIDFromAccessKey(accessKey)
ctx = withProjectID(ctx, projectID)
httplog.SetAttrs(ctx, slog.Uint64("projectId", projectID))
break
}
}
Expand Down
4 changes: 0 additions & 4 deletions proto/proto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ func (s SessionType) OrHigher() []SessionType {
}
return list
}

// Deprecated: Use SessionType_S2S instead.
// Note: Remove this after some time.
const SessionType_InternalService = SessionType_S2S