Relayer: unmarshal only when the txnReceipt is not empty#328
Merged
Relayer: unmarshal only when the txnReceipt is not empty#328
Conversation
Member
|
thanks for the PR, this looks right, as sometimes it can be empty, its true for instance if we didn't find the txn receipt object because of a timeout, etc. |
VojtechVitek
reviewed
Dec 1, 2025
Contributor
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
Thanks for the fix @david-littlefarmer 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metaTxnReceipt.TxnReceiptmay sometimes be an empty string.To avoid the unexpected end of JSON input error, we only unmarshal when the string is non-empty.
Or is this an unexpected case that we should treat as an error?