-
Notifications
You must be signed in to change notification settings - Fork 7
Added Boilerplates #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Boilerplates #250
Conversation
Deploying sequence-unity with
|
| Latest commit: |
06e345e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f6477c7.sequence-unity.pages.dev |
| Branch Preview URL: | https://demo-boilerplates.sequence-unity.pages.dev |
BellringerQuinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy! The UI looks amazing!
I had a few questions for you, mostly out of curiosity, and a couple nitpicks.
One other thing I noticed is with respect to how you're assembling your UI classes. It looks like a lot of them work via a similar flow, with an initial state or view and then as you navigate through the page, the code toggles between different states or views. This is a very similar structure to the UIPanel + UIPage structure that is used elsewhere in the SDK - with UIPanel's being what a page is in your context and a UIPage being analogous to a state. Without trying to shoehorn you into using a different paradigm, there are a couple things that could be advantageous here for your UI - UIPanel's keep track of UIPages pushed to them in a stack by default (making it easy to handle "Back" buttons on Android for example), UIPages automatically handle their animations through implementations of the ITween interface as dependencies, and using UIPanels+UIPages would likely allow you to simplify your SequenceSampleUI code a bit. No pressure or anything; do whatever you think is best here
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/BoilerplateController.cs
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/FileStorage.cs
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/ImageHighlightAnimation.cs
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/MessagePopup.cs
Outdated
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/QrCodeView.cs
Outdated
Show resolved
Hide resolved
...ages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/SignMessage/SequenceSignMessage.cs
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceFrontend/Scripts/UI/FederatedAuthPopupPanel.cs
Outdated
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceFrontend/Scripts/UI/UIPanel.cs
Outdated
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceFrontend/Scripts/UI/MultifactorAuthenticationPage.cs
Outdated
Show resolved
Hide resolved
Packages/Sequence-Unity/Sequence/SequenceSDK/EmbeddedWallet/EOAWalletLinker.cs
Show resolved
Hide resolved
…lerplates namespace
Deploying sequence-unity with
|
| Latest commit: |
0accaa4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://57f63417.sequence-unity.pages.dev |
| Branch Preview URL: | https://demo-boilerplates.sequence-unity.pages.dev |
Deploying sequence-unity with
|
| Latest commit: |
3e03642
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8859f0f.sequence-unity.pages.dev |
| Branch Preview URL: | https://demo-boilerplates.sequence-unity.pages.dev |
Deploying sequence-unity with
|
| Latest commit: |
8170e25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0fb1c45.sequence-unity.pages.dev |
| Branch Preview URL: | https://demo-boilerplates.sequence-unity.pages.dev |
Deploying sequence-unity with
|
| Latest commit: |
70ed702
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://975c0adb.sequence-unity.pages.dev |
| Branch Preview URL: | https://demo-boilerplates.sequence-unity.pages.dev |
Packages/Sequence-Unity/Sequence/SequenceBoilerplates/Scripts/Common/MessagePopup.cs
Show resolved
Hide resolved
BellringerQuinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the BoilerplateFactory. I think we can come up with some cool flows using this idea
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: