Skip to content

Conversation

@andygruening
Copy link
Contributor

@andygruening andygruening commented Feb 11, 2025

Version Increment

Please ensure you have incremented the package version in the package.json as necessary.

  • I have incremented the package.json according to semantic versioning
  • No version increment is needed; the change does not impact SDK or Sample code/assets

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

@andygruening andygruening requested a review from a team February 11, 2025 17:11
@andygruening andygruening requested a review from a team as a code owner February 11, 2025 17:11
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 11, 2025

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06e345e
Status: ✅  Deploy successful!
Preview URL: https://1f6477c7.sequence-unity.pages.dev
Branch Preview URL: https://demo-boilerplates.sequence-unity.pages.dev

View logs

Copy link
Contributor

@BellringerQuinn BellringerQuinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy! The UI looks amazing!

I had a few questions for you, mostly out of curiosity, and a couple nitpicks.

One other thing I noticed is with respect to how you're assembling your UI classes. It looks like a lot of them work via a similar flow, with an initial state or view and then as you navigate through the page, the code toggles between different states or views. This is a very similar structure to the UIPanel + UIPage structure that is used elsewhere in the SDK - with UIPanel's being what a page is in your context and a UIPage being analogous to a state. Without trying to shoehorn you into using a different paradigm, there are a couple things that could be advantageous here for your UI - UIPanel's keep track of UIPages pushed to them in a stack by default (making it easy to handle "Back" buttons on Android for example), UIPages automatically handle their animations through implementations of the ITween interface as dependencies, and using UIPanels+UIPages would likely allow you to simplify your SequenceSampleUI code a bit. No pressure or anything; do whatever you think is best here

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0accaa4
Status: ✅  Deploy successful!
Preview URL: https://57f63417.sequence-unity.pages.dev
Branch Preview URL: https://demo-boilerplates.sequence-unity.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e03642
Status:⚡️  Build in progress...

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e03642
Status: ✅  Deploy successful!
Preview URL: https://e8859f0f.sequence-unity.pages.dev
Branch Preview URL: https://demo-boilerplates.sequence-unity.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8170e25
Status:⚡️  Build in progress...

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8170e25
Status: ✅  Deploy successful!
Preview URL: https://c0fb1c45.sequence-unity.pages.dev
Branch Preview URL: https://demo-boilerplates.sequence-unity.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70ed702
Status:⚡️  Build in progress...

View logs

@cloudflare-workers-and-pages
Copy link

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70ed702
Status: ✅  Deploy successful!
Preview URL: https://975c0adb.sequence-unity.pages.dev
Branch Preview URL: https://demo-boilerplates.sequence-unity.pages.dev

View logs

Copy link
Contributor

@BellringerQuinn BellringerQuinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the BoilerplateFactory. I think we can come up with some cool flows using this idea

@andygruening andygruening merged commit 6d50857 into master Feb 24, 2025
2 checks passed
@andygruening andygruening deleted the demo-boilerplates branch February 24, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants