Feature/marketplace checkout #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendant classes to the Integrations assembly so that Marketplace assembly can inherrit from Integrations assembly (using Transak and Sardine)
…ctibles and add missing tests
…tive names and fix implementation to new endpoint configuration and update test namings
…ntation and tests
…reating separate json converters for each enum
…m told I have invalid calldata when opening the link. I am also needing to mock the gas estimation as my estimator thinks the transaction will revert (which makes sense as I wouldn't be executing)
* FirstCommitForQr Qr Setup and exposure with link to add funds for the respective order chain id in native token address * More automatization on adding funds Detecting specifics straight from collectible order * Automated inputs for QR Included automated inputs for adding funds via qr transfer link. Fills Qr with selected order Order component information. * Updated qr token address setting Made check for nativetokenaddress placeholder to use in case ChainTokenAddress.Get(),(renamed) and also made some minor ui text updates. * Standarized to EIP-618 transfer link It includes all etheremum eip-618 compatible wallets (metamask is such). Also revisions on price names and formats
…quence/sequence-unity into Feature/marketplaceCheckout
…cating amounts to them until we can fulfill user's request) into its own class 'OrderOrchestrator' and use it as a dependency for both NftCheckout and SequenceCheckout. This fixes a bug where SequenceCheckout wouldn't request additional orders as the amount requested grew beyond the present order's availability (#268)
* Move order orchestration logic (requesting additional orders and allocating amounts to them until we can fulfill user's request) into its own class 'OrderOrchestrator' and use it as a dependency for both NftCheckout and SequenceCheckout. This fixes a bug where SequenceCheckout wouldn't request additional orders as the amount requested grew beyond the present order's availability * Optimize CheckoutPage load by making less API requests (re-ordering the way they are done)
…quence/sequence-unity into Feature/marketplaceCheckout
…at it drops trailing 0s after the decimal point '.' in numbers (failure to do so can cause encoding issues)
…s maintains existing functionality and allows us to ship updates to the SDK code just like the rest of the package. Otherwise, devs will need to import it via samples in order to use them and will miss out on any fixes we push out unless they re-import the samples (which would give them everything again). This makes the Boilerplate code immutable, but it makes it more effective as sample code and easier to get updated.
…en working for some time and aren't relevant with our new Boilerplate based UI system. I've left the UI tests in for now as a reference in case we ever do revisit them; if we do, we'll want to be careful about how many we write as the test suite can take a long time to run and can be difficult to effectively parallelize.
Contributor
Author
|
When we merge, we'll want to merge this docs PR 0xsequence/docs#40 |
#272) * Added ADR to explain marketplace + pay architecture. Additionally, added a github action to embed the mermaid diagram in the Readme * Embed the mermaid diagram directly into the ADR since it is timestamped
* Merge updateToNewBoilerplates branch into Feature/marketplaceCheckout * Fix date picker drodown options --------- Co-authored-by: Quinn Purdy <[email protected]>
andygruening
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing this PR, it is recommended to also review the monetization docs https://docs.sequence.xyz/sdk/unity/monetization/intro
#248, #258, #239, #262 are pre-requisites/included in this PR
For our future selves, I've also included an ADR in the README to explain why the architecture is structured the way it is. You may also find this helpful when digesting this PR.
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: