Fixed Account federation after recovering wallet from storage #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying sequence-unity with
|
| Latest commit: |
f04f7dd
|
| Status: | 🚫 Build failed. |
andygruening
changed the title
BellringerQuinn
approved these changes
Apr 14, 2025
Contributor
BellringerQuinn
left a comment
BellringerQuinn
left a comment
There was a problem hiding this comment.
Looks great! Thanks Andy!
Do you think we can remove this section on re-using the login panel for federation?
https://docs.sequence.xyz/sdk/unity/onboard/authentication/federated-accounts#re-using-the-default-loginpanel
It seems like this is no longer relevant with these changes? Is that correct?
...ence-Unity/Sequence/SequenceFrontend/Scripts/UI/Boilerplates/Common/BoilerplateController.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
BellringerQuinn
previously approved these changes
Apr 15, 2025
Contributor
BellringerQuinn
left a comment
BellringerQuinn
left a comment
There was a problem hiding this comment.
Sweet! Working now!
BellringerQuinn
previously approved these changes
Apr 15, 2025
BellringerQuinn
approved these changes
Apr 15, 2025
caballoninja
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, account federation fails after recovering a wallet from storage. When recovering the session, the call to SetupAuthenticator creates a new _sessionWallet and overwrites the sessionId, because TryToLoginWithStoredSessionWallet is not updating the _connectedWalletAddress value (first if-expression inside SetupAuthenticator equals to true - which creates a new _sessionWallet)
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: