Skip to content

Conversation

@caballoninja
Copy link
Contributor

@caballoninja caballoninja commented Apr 10, 2025

The parameters were wrong, would never find correct args for opening

Version Increment

Please ensure you have incremented the package version in the package.json as necessary.

  • I have incremented the package.json according to semantic versioning
  • No version increment is needed; the change does not impact SDK or Sample code/assets

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

The parameters were wrong, would never find correct args for opening
@caballoninja caballoninja requested a review from a team April 10, 2025 15:26
@caballoninja caballoninja requested a review from a team as a code owner April 10, 2025 15:26
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2025

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68f0821
Status:🚫  Build failed.

View logs

Copy link
Contributor

@BellringerQuinn BellringerQuinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and correct to me! Though I noticed this code doesn't seem to be used anywhere? Should we maybe add a demo using it?

@caballoninja caballoninja merged commit 80390f5 into master Apr 14, 2025
1 of 2 checks passed
@caballoninja caballoninja deleted the fix/SellOfferPanelParameters branch April 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants