Skip to content

Conversation

@BellringerQuinn
Copy link
Contributor

When building, check SequenceConfig for the url scheme; if set and if it contains uppercase characters, log a warning and open the warning popup window (as these logs may get cleared during the build process) warning the user that using uppercase letters may cause issues with deep linking on some platforms (e.g. while it works on MacOS, it doesn't work on Android)

Version Increment

Please ensure you have incremented the package version in the package.json as necessary.

  • I have incremented the package.json according to semantic versioning
  • No version increment is needed; the change does not impact SDK or Sample code/assets

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

…rror and open our warning popup to indicate that using uppercase characters in the URL scheme may lead to deeplinking issues on certain platforms (e.g. Android)
@BellringerQuinn BellringerQuinn requested a review from a team May 5, 2025 15:17
@BellringerQuinn BellringerQuinn requested a review from a team as a code owner May 5, 2025 15:17
Copy link
Contributor

@andygruening andygruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BellringerQuinn BellringerQuinn merged commit a5d6d46 into master May 16, 2025
1 of 2 checks passed
@BellringerQuinn BellringerQuinn deleted the Fix/betterUrlSchemeCheck branch May 16, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants