Skip to content

228 marketplace reader support#263

Closed
ZemindJan wants to merge 7 commits intomasterfrom
228-marketplace-reader-support
Closed

228 marketplace reader support#263
ZemindJan wants to merge 7 commits intomasterfrom
228-marketplace-reader-support

Conversation

@ZemindJan
Copy link
Contributor

No description provided.

@ZemindJan ZemindJan requested review from a team and colezemind December 17, 2024 14:53
@ZemindJan ZemindJan requested a review from a team as a code owner December 17, 2024 14:53
@ZemindJan ZemindJan force-pushed the 228-marketplace-reader-support branch from 6c2ea09 to bd6b8e9 Compare December 17, 2024 17:25
@BellringerQuinn BellringerQuinn changed the base branch from master to v2 January 20, 2025 16:01
Comment on lines +1 to +3
[CoreRedirects]
+FunctionRedirects=(OldName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithLowestListingsAsync",NewName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithLowestListingsFirstAsync")
+FunctionRedirects=(OldName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithHighestListingsFirstAsync",NewName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithHighestPricedOffersFirstAsync") No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know this existed
Very cool

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSuccessCallback<FSeqListCollectiblesReturn> OnSuccess,
const FFailureCallback& OnFailure)
{
const FString Endpoint = "ListCollectibleOffersWithHighestPricedOfferFirst";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong endpoint. Example curl request:

curl -X POST 'https://marketplace-api.sequence.app/polygon/rpc/Marketplace/ListCollectibles' -H 'Content-Type: application/json' -H 'X-Access-Key: oesk7yu5tjNfQElu5HjuUunAAAAAAAAAA' -d '{"side":"offer","contractAddress":"0x079294e6ffec16234578c672fa3fbfd4b6c48640","filter":{"includeEmpty":false,"searchText":""}}'

I understand your confusion though here; it's changed a few times. Should be finalized now though

#include "CoreMinimal.h"

namespace IndexerEndToEndTestsCommon
namespace MarketplaceEndToEndTestsCommon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I think I see what happened above - copy/paste error 😄

Wrong file name here

public:
// Properties
UPROPERTY(EditAnywhere, BlueprintReadWrite)
int ID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'm not sure if the id's are parsing properly. When I run the test I see all the id's are 0

{
"iD": 0,
"chainId": 137,
...
}

The are more fields that can be added as well, see Unity code as an example, we can add them now or in a later ticket/pr

@ZemindJan ZemindJan force-pushed the 228-marketplace-reader-support branch from c8b10d7 to 776a390 Compare March 31, 2025 17:30
Base automatically changed from v2 to master May 8, 2025 10:24
@andygruening
Copy link
Contributor

Closing because this was already merged into v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants