Skip to content

Feature/playfab validate input#267

Merged
BellringerQuinn merged 4 commits intomasterfrom
Feature/playfabValidateInput
Jan 17, 2025
Merged

Feature/playfab validate input#267
BellringerQuinn merged 4 commits intomasterfrom
Feature/playfabValidateInput

Conversation

@BellringerQuinn
Copy link
Contributor

@BellringerQuinn BellringerQuinn commented Jan 8, 2025

Added some simple validation for the username, email, and password we send to PlayFab for authentication. Failure to do so can cause crashes, specifically if empty values are provided

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

…g a new account and logging in do some form of validation, whether via federation or a new session. At least for now, let's only log a warning when federation fails due to failed login (much like we do when a basic login fails) - an error log during a test causes the test to fail
@BellringerQuinn BellringerQuinn requested a review from a team January 8, 2025 19:55
@BellringerQuinn BellringerQuinn requested a review from a team as a code owner January 8, 2025 19:55
@BellringerQuinn BellringerQuinn merged commit fad349b into master Jan 17, 2025
1 check passed
@BellringerQuinn BellringerQuinn deleted the Feature/playfabValidateInput branch January 17, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants