S-162 Prevent frontrunning permit DOSing intent#75
Merged
shunkakinoki merged 8 commits intomasterfrom Nov 26, 2025
Merged
Conversation
ScreamingHawk
force-pushed
the
c4-s162
branch
from
910fbe0 to
36ccb16
Compare
Member
|
LGTM this is not Medium severity |
Agusx1211
previously approved these changes
Nov 26, 2025
…ermit handling logic
shunkakinoki
dismissed stale reviews from Agusx1211 and themself
via
fab84de
…cription hash to intent signature
… intent signature computation
…t performance adjustments and ensure accuracy in gas usage metrics. Minor updates made to individual test cases for consistency.
…lity and maintainability. Adjusted try-catch structure for better clarity in handling potential frontrunning scenarios.
…roved readability. Consolidated call parameters into a single line for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-162 An attacker can block users from calling depositToIntentWithPermit()
https://code4rena.com/audits/2025-11-sequence-transaction-rails/submissions/S-162
Issue: An attack can read the permit signature from the mempool and front run the
token.permitcall, preventing thedepositToIntentWithPermitcall from passing.Analysis: This DOS can be run against any
depositToIntentWithPermitcall. While a user could retry the transaction by callingdepositToIntentwith the same signatures, excluding the permit call, this requires an additional transaction. IIRC This flow is not for intent addresses (that only have access to pre-approved transactions) so we should be fine to retry, but it's an annoyance we could prevent.Fix: Try/catch the
token.permit()call, ignoring failure. If the permit call was frontrun, the following transfer call will pass.