Merged
Conversation
Agusx1211
previously approved these changes
Nov 26, 2025
…recent changes in test performance and gas usage. Adjustments made to various test cases for accuracy and consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-538 Excess ETH Can Be Permanently Locked in Direct Calls to TrailsRouter
https://code4rena.com/audits/2025-11-sequence-transaction-rails/submissions/S-538
Issue:
msg.valuevalidation is inconsistent and doesn't require an exact value.Analysis: When ERC-20 is used, the exact supplied amount is used. For native token interactions, we check
msg.value < amountand do not do0checks when msg.value is unexpected. In practice, this is misconfiguration of the payload and shouldn't happen, but for safety it makes sense to check for this.Fix: Changes
msg.value < amountchecks tomsg.value != amount. Addsmsg.value == 0validation for ERC20 usages.NOTE: I've also removed references to
ETHin favour ofValueto support chains that doesn't useETHas the native token.NOTE2: This assumes we have no flows that are expected to send ERC20 AND native tokens in the same transaction.