Skip to content

RequireUtils 'self' uses address(this) instead of msg.sender#89

Closed
ScreamingHawk wants to merge 1 commit intoquantstampfrom
quant-s-2
Closed

RequireUtils 'self' uses address(this) instead of msg.sender#89
ScreamingHawk wants to merge 1 commit intoquantstampfrom
quant-s-2

Conversation

@ScreamingHawk
Copy link
Contributor

This change helps enforce the default context retention for the intent address by expecting delegate calls when making xxxSelf requests.

I'm impartial on this one. From a gas and complexity standpoint I think keeping msg.sender is the right approach Maybe the terminology self should be updated to sender to be less ambiguous?

A cleaner approach would be to remove all the xxxSelf functions and expect calls to populate msg.sender/address(this) using hydrate logic. This would be even more gas inefficient.

@Agusx1211
Copy link
Member

I don't think it is worth doing this change at this stage, even a name change seems unnecessary since we have been using this naming schema for a long time and it hasn't caused confusion so far. We can change it in v2.

@Agusx1211 Agusx1211 closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants