RequireUtils 'self' uses address(this) instead of msg.sender#89
Closed
ScreamingHawk wants to merge 1 commit intoquantstampfrom
Closed
RequireUtils 'self' uses address(this) instead of msg.sender#89ScreamingHawk wants to merge 1 commit intoquantstampfrom
ScreamingHawk wants to merge 1 commit intoquantstampfrom
Conversation
Member
|
I don't think it is worth doing this change at this stage, even a name change seems unnecessary since we have been using this naming schema for a long time and it hasn't caused confusion so far. We can change it in v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change helps enforce the default context retention for the intent address by expecting delegate calls when making
xxxSelfrequests.I'm impartial on this one. From a gas and complexity standpoint I think keeping
msg.senderis the right approach Maybe the terminologyselfshould be updated tosenderto be less ambiguous?A cleaner approach would be to remove all the
xxxSelffunctions and expect calls to populatemsg.sender/address(this)usinghydratelogic. This would be even more gas inefficient.