Skip to content

feat: swap api getSwapQuoteV2 (Lifi)#371

Merged
taylanpince merged 5 commits intomasterfrom
feat/lifi_integration
Apr 9, 2025
Merged

feat: swap api getSwapQuoteV2 (Lifi)#371
taylanpince merged 5 commits intomasterfrom
feat/lifi_integration

Conversation

@VGabriel45
Copy link
Contributor

No description provided.

@VGabriel45 VGabriel45 requested review from a team and 0xsequence-bot as code owners April 2, 2025 10:47
@VGabriel45
Copy link
Contributor Author

Please do not merge yet.

@SamueleA
Copy link
Contributor

SamueleA commented Apr 4, 2025

I can deduce from this code that the getSwapPricesV2 endpoint will not use the 0xeeee... address from 0x anymore. If that's true, then we should be able to completely delete the NATIVE_TOKEN_ADDRESS_0X_SWAP from web-sdk.

However, I'm seeing that getSwapPrices is still using NATIVE_TOKEN_ADDRESS_0X_SWAP in its code.... Should that be removed also? Are we waiting for getSwapPricesV2?

I would also like it if you could test a full swap flow with native currencies to makes sure that the system works correctly because getSwapQuote and getSwapPrices are supposed to work together, so I'm wondering if a change in one will have a change and the other.

@taylanpince taylanpince merged commit 6b2c187 into master Apr 9, 2025
1 check passed
@taylanpince taylanpince deleted the feat/lifi_integration branch April 9, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants