Skip to content

Conversation

@remimd
Copy link
Member

@remimd remimd commented Jun 15, 2025

…ception

@remimd remimd requested a review from Copilot June 15, 2025 11:22
@remimd remimd self-assigned this Jun 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes exception re-raising to preserve original tracebacks, streamlines DI registrations in the core message module, and bumps the UV setup action version.

  • Replace raise exc with bare raise in history and retry middlewares.
  • Simplify @injection.singleton calls by removing explicit targets and generic parameters in cq/_core/message.py.
  • Upgrade astral-sh/setup-uv action to v6 in CI.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
tests/helpers/history.py Switched from raise exc to bare raise to keep full traceback.
cq/middlewares/retry.py Removed capturing exception variable and use bare raise.
cq/_core/message.py Consolidated @injection.singleton calls, removed generics/on=.
.github/actions/environment/action.yml Updated astral-sh/setup-uv action version to v6.
Comments suppressed due to low confidence (2)

cq/_core/message.py:36

  • Removing the explicit on=CommandBus parameter might alter the intended injection key; consider adding on=CommandBus to ensure the bus is registered correctly.
@injection.singleton(inject=False, mode="fallback")

cq/_core/message.py:48

  • Without on=QueryBus, the decorator may not register to the correct injection target; please specify on=QueryBus to maintain consistency.
@injection.singleton(inject=False, mode="fallback")

@remimd remimd changed the title I've just learned that raise without argument, reraise the current ex… Raise without argument, reraise the current exception Jun 15, 2025
@remimd remimd merged commit 49d86d7 into dev Jun 15, 2025
5 checks passed
@remimd remimd deleted the raise branch June 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants