Skip to content

Conversation

@remimd
Copy link
Member

@remimd remimd commented Sep 9, 2025

No description provided.

@remimd remimd requested a review from Copilot September 9, 2025 11:43
@remimd remimd self-assigned this Sep 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the lifetime of bus instances from singleton to injectable, modifying the dependency injection behavior for command, event, and query buses in the CQ framework.

  • Updated bus factory functions to use @injectable instead of @singleton decorators
  • Modified FastAPI example documentation to reflect the change from singleton to injectable lifecycle
  • Removed unused singleton import from the FastAPI example

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
documentation/fastapi-example.md Updated example to use @injectable decorator and removed unused singleton import
cq/_core/message.py Changed bus factory functions from @singleton to @injectable lifecycle management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@remimd remimd merged commit 8add998 into dev Sep 9, 2025
5 checks passed
@remimd remimd deleted the bus_lifetime branch September 9, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants