Optimization of the implementation of RelatedEvents #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates several dependencies in the lock file (coverage 7.11.1→7.11.3, fastapi 0.121.0→0.121.1, python-injection 0.22.0→0.23.3, uv 0.9.7→0.9.8) and refactors the RelatedEvents implementation from a simple collector to an async task-based dispatcher.
Key Changes
- Dependency versions updated to their latest minor/patch releases
SimpleRelatedEventsreplaced withAnyIORelatedEvents- Events are now dispatched immediately when added via task spawning, rather than being collected and dispatched at context exit
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Updated package versions for coverage, fastapi, python-injection, and uv to newer releases |
| cq/_core/related_events.py | Refactored from buffered event collection to immediate async dispatch using AnyIO task groups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.