Remove some type: ignore
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves type annotations in the injection library to eliminate type: ignore comments by using more precise Protocol-based type definitions and better naming conventions for internal types.
Key Changes
- Converted the
_Decoratortype from a type alias to a Protocol with generic method signatures, enabling better type checking without requiringtype: ignore[type-arg]comments - Renamed internal types to follow Python conventions:
EntrypointDecorator→_EntrypointDecorator(private) and__MODULE→_default_module(more pythonic) - Updated dependency versions (fastapi, librt, platformdirs) in the lock file
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uv.lock | Updated dependency versions: fastapi 0.123.9→0.123.10, librt 0.6.3→0.7.0, platformdirs 4.5.0→4.5.1 |
| injection/entrypoint.py | Renamed EntrypointDecorator to _EntrypointDecorator to mark as internal/private type |
| injection/_core/asfunction.py | Added positional-only parameter marker / to __call__ method for consistency |
| injection/init.pyi | Changed _Decorator from type alias to Protocol, renamed __MODULE to _default_module, removed all type: ignore[type-arg] comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.