Skip to content

Conversation

nicholasio
Copy link
Member

Related Issue/RFC: #443

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: 388211e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nicholasio nicholasio requested a review from fabiankaegy July 8, 2025 14:29
@nicholasio nicholasio mentioned this pull request Jul 8, 2025
1 task
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be lots of unrelated changes in this diff? Could it be that there is some stuff on trunk that isn't on develop yet? Or some outdated base branch?

@@ -100,7 +100,10 @@ const run = async () => {

variables.wordpress_version = await getWordPressLatestVersion();

console.log(__dirname);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the console.logs should be in here

@fabiankaegy fabiankaegy linked an issue Jul 8, 2025 that may be closed by this pull request
1 task
@nicholasio
Copy link
Member Author

There seem to be lots of unrelated changes in this diff? Could it be that there is some stuff on trunk that isn't on develop yet? Or some outdated base branch?

develop was out of date and I pushed the PR with an updated develop branch before pushing the updated develop branch to remote and now github UI is not picking up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues on new scaffold
2 participants