-
Notifications
You must be signed in to change notification settings - Fork 22
Fix/corrupted images #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix/corrupted images #452
Conversation
🦋 Changeset detectedLatest commit: 388211e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be lots of unrelated changes in this diff? Could it be that there is some stuff on trunk
that isn't on develop
yet? Or some outdated base branch?
@@ -100,7 +100,10 @@ const run = async () => { | |||
|
|||
variables.wordpress_version = await getWordPressLatestVersion(); | |||
|
|||
console.log(__dirname); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the console.logs should be in here
develop was out of date and I pushed the PR with an updated develop branch before pushing the updated develop branch to remote and now github UI is not picking up |
Co-authored-by: Fabian Kägy <[email protected]>
Related Issue/RFC: #443
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Checklist: