Skip to content

Fixed Function in ServicesManager.php#1017

Merged
dkotter merged 2 commits into10up:developfrom
DAnn2012:patch-1
Jan 7, 2026
Merged

Fixed Function in ServicesManager.php#1017
dkotter merged 2 commits into10up:developfrom
DAnn2012:patch-1

Conversation

@DAnn2012
Copy link
Contributor

@DAnn2012 DAnn2012 commented Nov 2, 2025

Description of the Change

Replaced _e( __( ... ) ) with a single _e() call to eliminate redundant nesting of translation functions. This improves code clarity and aligns with WordPress localization best practices.

How to test the Change

Changelog Entry

Fixed - Bug fix
Fixed Function in ServicesManager.php

Credits

Props @DAnn2012

Checklist:

@DAnn2012 DAnn2012 requested review from a team, dkotter and jeffpaul as code owners November 2, 2025 21:37
@jeffpaul jeffpaul removed the request for review from a team November 3, 2025 01:10
@jeffpaul jeffpaul added this to the 3.8.0 milestone Nov 3, 2025
@jeffpaul jeffpaul moved this to Code Review in Open Source Practice Nov 3, 2025
@DAnn2012
Copy link
Contributor Author

Hello @jeffpaul and @dkotter

When you can, could you take a look at this PR of mine?

Thanks.

Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR here and sorry for the delay in getting this reviewed. I've left a suggestion to ensure we're using proper escaping on the translation here, let me know if this makes sense. Thanks!

@github-project-automation github-project-automation bot moved this from Code Review to In Progress in Open Source Practice Jan 7, 2026
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
@DAnn2012 DAnn2012 requested a review from dkotter January 7, 2026 20:22
@jeffpaul jeffpaul moved this from In Progress to Code Review in Open Source Practice Jan 7, 2026
@github-project-automation github-project-automation bot moved this from Code Review to QA Testing in Open Source Practice Jan 7, 2026
@dkotter dkotter merged commit ade0090 into 10up:develop Jan 7, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this from QA Testing to Done in Open Source Practice Jan 7, 2026
@dkotter dkotter modified the milestones: 3.8.0, 3.7.1 Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants