Fix new Plugin Check errors #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and ignore security advisory for that. Run WP 6.8 as our minimum in our E2E tests so Woo can be installed
4 tasks
…ia composer as it breaks PHPCS otherwise
dkotter
requested review from
peterwilsoncc
and removed request for
a team and
jeffpaul
4 tasks
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me with a minor change inline. I will push the change and then merge.
I've verified the changes in includes/Classifai/Features/ContentGeneration.php are removing unused items.
| - Another tag | ||
| - ... | ||
| EOD; | ||
| // phpcs:enable Squiz.PHP.Heredoc.NotAllowed |
Contributor
There was a problem hiding this comment.
Need to reenable all the sniffs. It's easier to do it like this rather than add individually.
(As this is outside the diff, the suggestion isn't displaying correctly.)
Suggested change
| // phpcs:enable |
peterwilsoncc
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
A newer version of Plugin Check was recently released and it is now flagging new things. This PR fixes those.
How to test the Change
Nothing really needed here other than ensuring the plugin checks pass
Changelog Entry
Credits
Props @dkotter
Checklist: