-
Notifications
You must be signed in to change notification settings - Fork 64
Added Admin Notice for Legacy Settings Deprecation #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on Hook is in Use
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
…ure/deprecate-legacy-settings
|
|
||
| ### Deprecated | ||
|
|
||
| - The legacy settings screen (enabled via the `classifai_use_legacy_settings_panel` filter) is now formally deprecated and scheduled for removal in a future release. An admin notice will be displayed when this filter is active. Please migrate to the new React-based settings experience (props [@zamanq](https://github.com/zamanq), [@jeffpaul](https://github.com/jeffpaul) via [#1036](https://github.com/10up/classifai/pull/1036)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future PRs, we generally don't update the changelog here and instead we make sure we have a changelog entry within the PR description. When doing a release, I'll pull all those changelog entries and update the changelog at that point
Description of the Change
Added the WP Admin notice for the legacy settings deprecation when the hook is in use. This is the Phase 1 of multiple future phases which will eventually remove the legacy settings code from the plugin. The notice is dismissible and can be made non-dismissible if needed.
In WP Admin Dashboard:

In Classifai Settings page:

Closes #1030
How to test the Change
add_filter( 'classifai_use_legacy_settings_panel', '__return_true' );in active theme's functions.php file.Changelog Entry
Credits
Props @zamanq
Checklist: