-
Notifications
You must be signed in to change notification settings - Fork 64
[WIP] feat/489: Add Rewrite Tone feature #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Yes, this is correct. We'll need to refactor the code that renders the experience right now to make it not dependent on the Content Generation Feature. My thought would be to go with the slotfill approach where each Feature can register what they need within the experience (and properly enqueue that) and then each Feature will also be responsible for enqueuing the default ChatUI code (with WordPress being smart enough to not load that multiple times if multiple Features are in use) |
@dkotter This is exactly how it is currently implemented. If you disable Content Generation but keep Rewrite Tone enabled, the ChatUI would still show, but the downside to this approach is that it makes it difficult to implement the UI that Fabian is suggesting. |
|
Noting optimal approach for 3.8.0 is to add this functionality in via button iteration on block toolbar / top toolbar / sidebar panel. In future release we can consider a chat-based experience, but for now looking to have this function in-context within the authoring/editing experience is the preference. |
|
@Sidsector9 thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch? |
Description of the Change
Closes #489
Screencast
The Tone Rewriting options are preserved in local storage so that the admin does not have to perform the same selection every time.
Screen.Recording.2025-03-03.at.4.57.22.PM.mov
How to test the Change
Changelog Entry
Credits
Props @jeffpaul @Sidsector9
Checklist: