Fix | Make plugin VIP compliant by removing usage of wp_remote_get#901
Conversation
| $request_params | ||
| ); | ||
| } | ||
| $response = safe_wp_remote_get( $request_url, $request_params ); |
There was a problem hiding this comment.
So previously we were setting a higher timeout value here to give the request longer to succeed. That is now removed and I think we'll want to add that back.
There was a problem hiding this comment.
@dkotter we have that value in the helper function here
classifai/includes/Classifai/Helpers.php
Line 698 in 128c517
…usage-of-wp_remote_get
|
@sksaju Apologies, merged this in but didn't realize this was raised against |
|
Would also be nice to consider splitting out the VIPCS from https://github.com/10up/classifai/blob/develop/.github/workflows/phpcs.yml into specific YML for https://github.com/10up/wpcs-action/ that's VIPCS only so we can add that check and a related readme badge to note ClassifAI is passing VIPCS? |
|
@jeffpaul, I've created a separate with a single missing fix: #987 |
Description of the Change
This update replaces all usages of wp_remote_get with the vip_safe_wp_remote_get function to ensure compatibility with WordPress VIP coding standards and improve overall security and reliability when making HTTP requests.
Closes #791
How to test the Change
Changelog Entry
Checklist: