Fix display of Smart Crop thumbnails on WordPress UI

[mendezcode]

Description of the Change

Introduces a filter on wp_prepare_attachment_for_js and replaces the medium thumbnail size (150x300) with the thumbnail thumbnail size (150x150), which effectively displays the cropped image thumbnail on the WordPress Media Library.

💡 Since the wp_prepare_attachment_for_js filter works within wp-ajax.php, there is no way to access the $pagenow global, to possibly filter the current page to the WordPress Media Library and potentially make the thumbnail override on that page only, and not globally (within the JavaScript data, that is).

This change replaces the medium thumbnail with the thumbnail size only for the JavaScript data used with the frontend Backbone models. It is a global change, but only within JavaScript.
 

Closes #768

How to test the Change

1. Ensure ClassifAI is active and the Smart Crop feature
2. Upload an image to the Media Library
3. View the image and its thumbnail in the uploads directory, see properly smart-cropped image
4. Confirm within the WP UI that the cropped image is shown instead of the default center-crop one

Changelog Entry

Fixed - Smart crop thumbnails not showing in WordPress UI

Credits

Props @kmgalanakis , @dkotter

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added Critical Flows, Test Cases, and/or End-to-End Tests to cover my change.
• All new and existing tests pass.

[iamdharmesh]

Thanks a lot for the PR @mendezcode. LGTM.

@dkotter, since we are updating the medium size with the thumbnail one, I’m tagging you here to check if you have any concerns with it. I did a quick check on this and couldn’t find a better solution.

[dkotter]

So in testing this out, I'm not seeing this working. I get the exact same images used both on this branch and on develop, unless there's something I'm missing here?

[iamdharmesh]

I'm not seeing this working. I get the exact same images used both on this branch and on develop, unless there's something I'm missing here?

Here is how it looks to me. Maybe you should try with regenerate thumbnails?

on develop	on this branch

[dkotter]

Here is how it looks to me. Maybe you should try with regenerate thumbnails?

Working now, I thought I had the Feature enabled but did not, so the code wasn't loading 😅

This is working though I left a few comments. I don't necessarily love that this is a global change, does make me a bit worried this could impact other areas unintentionally but not seeing anything doing a quick review of the admin