-
Notifications
You must be signed in to change notification settings - Fork 158
Release: 2.0.1 #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.0.1 #1136
Conversation
|
@peterwilsoncc @dkotter not certain if we similarly need to version bump to 2.0.1 in distributor/includes/rest-api.php Line 385 in 46a26fa
distributor/includes/classes/ExternalConnections/WordPressExternalConnection.php Line 279 in 46a26fa
|
|
@dkotter @peterwilsoncc @ravinderk open to any of the following items currently in the 2.0.1 milestone getting wrapped up, merged, and included in the release:
But come Monday, we'll want to continue with the 2.0.1 in any case to get the fix out for the distributed author issue (and other updates in the release). |
Only needed for crossing the divide so no need to bump. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've just merged in a minor markdown fix so tests will need to rerun.
iamdharmesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
develop, create a release branch namedrelease/X.Y.Zfor your changes.distributor.php,package.json,readme.txtandtests/php/bootstrap.phpif it does not already reflect the version being released. Indistributor.phpupdate both the plugin "Version:" property and the pluginDT_VERSIONconstant.webpack.config.release.js.CHANGELOG.md.CREDITS.mdfile with any new contributors, confirm maintainers are accurate.README.mdis geared toward GitHub andreadme.txtcontains WordPress.org-specific content. The two are slightly different.@sincetags indicate the new version, replacingx.x.x,n.e.x.tand other placeholders.develop(or merge the Pull Request), then do the same fordevelopintotrunk(git checkout trunk && git merge --no-ff develop).trunkcontains the stable development version.drafttoready to merge.stablebranch to ensure the contents of the diffs are as expected.stablebranch and test it locally to ensure everything works as expected. It is recommended that you rename the existingdistributordirectory and check outstablefresh because switching branches does not delete files. This can be done withgit clone --single-branch --branch stable git@github.com:10up/distributor.gitstablebranch. Paste the changelog fromCHANGELOG.mdinto the body of the release and include a link to the closed issues on the milestone. The release should now appear under releases.stablebranch.Due date (optional)field) and link to GitHub release (in theDescriptionfield), then close the milestone.X.Y.Zdo not make it into the release, update their milestone toX.Y.Z+1,X.Y+1.0,X+1.0.0, orFuture Release.