-
Notifications
You must be signed in to change notification settings - Fork 7
Only load block assets on frontend when block exists. #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesmorrison
wants to merge
9
commits into
develop
Choose a base branch
from
feature/199-tab-and-tab-items-block-assets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fd6436a
Only load block assets on frontend when block exists.
07e146d
Update includes/blocks/block-editor/tabs-item/register.php
jeffpaul 7f9486c
Update includes/blocks/block-editor/tabs/register.php
jeffpaul 3a582d1
Merge branch 'develop' into feature/199-tab-and-tab-items-block-assets
jamesmorrison f3cc6c2
Refactor tabs block to use viewScript in block.json for conditional f…
jamesmorrison 2da4ae7
Resolved merge conflict.
jamesmorrison 27faf6d
Resolve linting error.
jamesmorrison 132ff74
Resolve linting error.
jamesmorrison e8d4de8
Fix failing test.
jamesmorrison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1 @@ | ||
| // import foo from './components/bar'; | ||
| import Tabs from '@10up/component-tabs'; | ||
|
|
||
| // eslint-disable-next-line no-new | ||
| new Tabs('.tabs', { | ||
| orientation: 'horizontal', | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /** | ||
| * Tabs Block - Frontend View Script | ||
| * | ||
| * @package PublisherMediaKit\Blocks\Tabs | ||
| */ | ||
|
|
||
| import Tabs from '@10up/component-tabs'; | ||
|
|
||
| // Initialize tabs on frontend | ||
| // eslint-disable-next-line no-new | ||
| new Tabs('.tabs', { | ||
| orientation: 'horizontal', | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safe to delete this file. Remember to remove the entry point from
package.jsonwhile doing so.