Conversation
- Add separate manifests for Chrome and Firefox - Fix cross-browser API compatibility (browser vs chrome) - Fix Chrome MV3 async messaging (sendResponse pattern) - Fix CustomEvent detail passing via JSON serialization - Add auto-reload on settings change - Add tabs permission for reload functionality - Add .dev marker for debug mode detection - Add comprehensive tests (188 total)
Chrome MV3 service workers can be inactive when popup opens, causing sendMessage to return undefined. Added exponential backoff retry logic (50ms, 100ms, 200ms) to handle service worker wake-up delay. - Add MESSAGE_RETRY_DELAYS_MS constant for backoff intervals - Validate response is not undefined before returning - Check chrome.runtime.lastError in Chrome context - Add 5 new tests for retry scenarios
… access Settings were not consistently applied on page reload because page-script runs before content-script can provide config via events. Changes: - Add localStorage mirroring in storage.ts (syncToLocalStorage) - page-inject.ts now syncs settings before injecting page-script - page-script.ts reads localStorage on every getConfig() call - .gitignore: exclude extension/manifest.json (build artifact) This eliminates the race condition where fetch interception used default settings instead of user-configured values.
- Build and publish both Firefox and Chrome extensions on release - Create separate browser-specific zip files (-firefox.zip, -chrome.zip) - Add Chrome Web Store publishing step using browser-actions/release-chrome-extension - Update GitHub Release notes with both store links - Document required GitHub secrets (CHROME_EXTENSION_ID, CHROME_CLIENT_ID, CHROME_CLIENT_SECRET, CHROME_REFRESH_TOKEN) - Fix lint error in messages.ts for chrome.runtime.lastError typing
feat(ci): add Chrome Web Store publishing to release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Chrome Support
manifest.chrome.jsonfor Chrome-specific configuration--target=chrome/--target=firefoxBug Fixes
Architecture
page-inject.tsnow syncs settings to localStorage before injecting page-scriptpage-script.tsreads localStorage on every fetch interception (source of truth)messages.tsvalidates responses and retries on undefined (Chrome SW issue)Test plan