Conversation
zachleat
reviewed
Mar 4, 2026
Ryuno-Ki
reviewed
Mar 5, 2026
Ryuno-Ki
reviewed
Mar 5, 2026
Ryuno-Ki
reviewed
Mar 5, 2026
| {%- endif %} | ||
|
|
||
| <!-- Web Awesome Kit --> | ||
| <link rel="stylesheet" href="https://kit.webawesome.com/a2ff939369d44af1.css" crossorigin="anonymous"> |
Contributor
There was a problem hiding this comment.
Is it feasible to have SRI (Sub-Resource Integrity) here? In case kit.webawesome.com is compromised.
Alternatively self-hosting.
Ryuno-Ki
reviewed
Mar 5, 2026
| </div> | ||
|
|
||
| <wa-dialog id="promo-dialog" class="promo-dialog" light-dismiss without-header> | ||
| <iframe class="video-player" src="https://player.vimeo.com/video/1168551192?h=6ba669b3ff&badge=0&autopause=0&player_id=0&app_id=58479" frameborder="0" allow="autoplay; fullscreen; picture-in-picture; clipboard-write; encrypted-media; web-share" referrerpolicy="strict-origin-when-cross-origin" title="Now on Kickstarter: Build Awesome — Collaborate on Web Sites That Last"></iframe> |
Contributor
There was a problem hiding this comment.
I wouldn't expect Vimeo to be around for long:
https://www.businessinsider.com/vimeo-laying-off-staff-after-billion-sale-to-bending-spoons-2026-1
Ryuno-Ki
reviewed
Mar 5, 2026
Ryuno-Ki
reviewed
Mar 5, 2026
| <wa-button | ||
| variant="brand" | ||
| appearance="accent" | ||
| href="{{ config.kickstarterUrl }}" |
Contributor
There was a problem hiding this comment.
Conceptually this ought to be an <a> wrapped by a HTML web component, but I guess wa-button isn't designed that way.
If the web component cannot load (network fluke or what have you) this link isn't actionable.
Ryuno-Ki
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a popup modal for the Buildawesome Kickstarter