WIP: Adds (hacky) tracking of paginations#38
Open
slightlyoff wants to merge 11 commits into11ty:mainfrom
Open
Conversation
Author
|
Ok, added some minimal tests. Can you take a look, @zachleat? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
The basic idea is that blocks declared in pages iterated over via frontmatter paginations will be available to the paginating page as well as the pages declaring the blocks. This has some limitations. For instance, iterations over collections aren't handled; e.g. in the front page of the 11ty base blog project. Sites that grab
templateContentfrom a collection without a paginating over the same collection won't get merged blocks, but this is the status quo so I'm not sure how bad that is.