Skip to content

update giggsey/libphonenumber-for-php-lite#38

Merged
bram123 merged 3 commits into123inkt:masterfrom
danny-janse:feature/update-giggsey-libphonenumber
Aug 29, 2025
Merged

update giggsey/libphonenumber-for-php-lite#38
bram123 merged 3 commits into123inkt:masterfrom
danny-janse:feature/update-giggsey-libphonenumber

Conversation

@danny-janse
Copy link
Contributor

Update giggsey/libphonenumber-for-php-lite from version ^8 to ^9.

Copilot AI review requested due to automatic review settings August 29, 2025 09:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the giggsey/libphonenumber-for-php-lite library dependency from version ^8 to ^9, which includes breaking changes that require code adaptations.

  • Update composer dependency to version ^9.0.12
  • Adapt method signatures and API calls to match the new library version
  • Replace deprecated format constants with library-specific enum values

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
composer.json Updates library dependency from ^8.13.11 to ^9.0.12
src/PhoneNumberParseService.php Updates parse method call and converts number type handling to use enum instead of integer
src/PhoneNumberFormatService.php Replaces format constants with PhoneNumberFormat enum values
src/PhoneNumber/PhoneNumberFormatOptions.php Changes format constants from library enum references to hardcoded integers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bram123 bram123 self-requested a review August 29, 2025 09:38
@bram123 bram123 merged commit 813a2ef into 123inkt:master Aug 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants