-
Notifications
You must be signed in to change notification settings - Fork 0
Setup the initial repo for publication #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 107 commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
197585b
init
c3c7804
Add php 7.3 to defaults
558dff9
Add gitattributes file
3d20d3a
Group gitattributes
6754b25
Add ts file to gitattributes
a763ddb
Merge pull request #3 from 123inkt/gitattributes
frankdekker 4946fd5
Add phpcs, phpstan, phpmd
2af5db6
Remove PHP7.0 build/requirement
87e3af4
Update scripts to start with "check" or "fix"
2e710f5
Add auto-assign action
a2ecbf6
Only auto-assign on PRs to master
3d07166
Only add two reviewers instead of all
0c33528
Move auto-assign config to separate file
8c99b4a
Fix auto assign workflow path
54d610f
Fix capitalization of github username because auto-assign doesn't acc…
fb26fb5
Change auto-assign amount to 1 as that is the current limit for priva…
47ea1ef
Merge pull request #4 from 123inkt/add-code-tools
PrinsFrank 1c5bb23
Merge pull request #5 from 123inkt/auto-assign
PrinsFrank 6f07419
Remove beStrictAboutCoversAnnotation from phpunit.xml. The regular @c…
frankdekker 1c2e5a0
Merge pull request #6 from 123inkt/update-phpunit-configuration
frankdekker 1d92df5
Revert "Remove beStrictAboutCoversAnnotation from phpunit.xml."
PrinsFrank 994397e
Merge pull request #7 from 123inkt/revert-6-update-phpunit-configuration
PrinsFrank c170f19
Remove beStrictAboutCoversAnnotation from phpunit.xml.
frankdekker 1d301c3
Add requirements matrix for tests
1170621
Remove trailing slash phpunit.xml.dist
e82e5c4
Add composer stability flags to matrix and split up quality checks to…
a874bcd
Merge pull request #10 from 123inkt/remove-trailing-slash-phpunit
PrinsFrank e153227
Merge pull request #8 from 123inkt/update-phpunit-config
PrinsFrank e1cf4b5
Merge pull request #9 from 123inkt/add-requirements-matrix
PrinsFrank 71aaa7c
Update php codesniffer for several PSR12 fixes
90e4eae
Merge pull request #11 from 123inkt/update-codesniffer-for-several-ps…
PrinsFrank dd1a850
Fix yml indenting for test workflow job
2f74ad5
Merge pull request #12 from 123inkt/fix-yml-indenting-for-test-workfl…
PrinsFrank 1d47745
Don't auto assign when already assigned
395b757
Don't auto assign when already assigned
07b50d8
Don't auto assign when already assigned
557797b
Don't auto assign when already assigned
3475417
Don't auto assign when already assigned
ab26cb2
Don't auto assign when already assigned
96c52f9
Merge pull request #15 from 123inkt/dont-auto-assign-when-already-ass…
PrinsFrank 2ebb2fe
Change composer check command to array shorthand notation. fixes #16
a643af4
Remove PHPStan symfony from composer
b93ffbb
Disable coverage on test runs
a332fd3
Merge pull request #17 from 123inkt/change-composer-check-to-shorthan…
PrinsFrank fc15ee4
Merge pull request #18 from 123inkt/remove-phpstan-symfony-from-composer
PrinsFrank f73a0cf
Merge pull request #19 from 123inkt/disable-coverage-on-test-runs
PrinsFrank 568f3ad
Remove issue templates as those are moved to the .github repo
PrinsFrank 8980f6a
Add CODEOWNERS file to auto assign the Reviewer team to all new PRs
PrinsFrank cdea4ba
Merge pull request #20 from 123inkt/remove-issue-templates-that-are-m…
PrinsFrank d84fe0d
Merge pull request #21 from 123inkt/add-code-owners
PrinsFrank 6121c27
Fix round robin assign
PrinsFrank 29ce3ba
Merge pull request #22 from 123inkt/fix-round-robin-assign
PrinsFrank eacb5b2
bump minimum php version to 7.2
frankdekker e47bf50
update github work flow and readme.md
frankdekker 0171389
Merge pull request #23 from 123inkt/php-version-and-gitignore-updates
frankdekker 55df693
Remove duplicate auto assign from the template repository as it is no…
42723fb
Merge pull request #24 from 123inkt/remove-duplicate-auto-assign
PrinsFrank d2d2b09
Php update (#25)
bram123 37eabca
US75628_TT_upgrade-to-php-7.4 (#26)
davekok b4bb027
Update composer.json (#27)
bram123 9a6274f
Update the working at 123inkt url (#28)
frankdekker d5a074c
Add 8.1 to skeleton test.yml (#29)
bram123 e0864f1
Update phpunit.xml.dist
bram123 c5bbf45
Merge pull request #30 from 123inkt/bram123-patch-1
frankdekker 24e79eb
Update phpstan version
frankdekker 81fa8d0
Remove 7.4 from minimum version
frankdekker 62d6e65
Update composer config
frankdekker 2405edd
Update composer config
frankdekker 427cabe
Merge pull request #31 from 123inkt/Update-phpstan-version
frankdekker b6e9fff
Update developers and recruitment url
frankdekker 38d45a3
Merge pull request #32 from 123inkt/Update-company-it-info
frankdekker dc178de
Update phpmd and phpcs rules
frankdekker 54bb452
Merge pull request #33 from 123inkt/Update-phpmd-and-phpcs-rules
frankdekker d8bf50e
Improve phpmd ruleset
frankdekker 6e57238
Add phpunit file coverage inspection
frankdekker c1cd31f
Only run phpfci when coverage.xml exists
frankdekker 5856e3e
Only run phpfci when coverage.xml exists
frankdekker 3e2b41c
Only run phpfci when coverage.xml exists
frankdekker 61c4bc6
Merge pull request #34 from 123inkt/Update-phpmd-ruleset
frankdekker 4ede640
Merge pull request #35 from 123inkt/Add-phpunit-file-coverage-inspection
frankdekker 9d5f52e
Update test.yml (#36)
bram123 a3f34aa
Add PHP 8.2 to skeleton
bram123 948bf8d
Create renovate.json
bram123 1018bc4
Update actions/checkout action to v3 (#43)
renovate[bot] 68b2c53
Update dependency digitalrevolution/phpunit-file-coverage-inspection …
renovate[bot] a062c3a
Update skeleton php and package version
frankdekker f687fa6
Update skeleton php and package version
frankdekker 1e72b98
Include PHP8.3 in test matrix
frankdekker b30e175
Merge pull request #48 from 123inkt/Update-skeleton-package-versions
frankdekker ec73639
Update test.yml (#49)
bram123 d2d2f87
Update phpstan (#52)
bram123 a19d02b
Update dependency phpunit/phpunit to v12 (#53)
renovate[bot] e67eec2
Setup the initial repo for publication
RubenKluft db75374
Remove pmd-gitlab-renderer to fix github pipeline
RubenKluft 023e154
Update pipeline to php version >=8.3
RubenKluft 0aa5205
Update pipeline to run only unit:test as coverage is separate
RubenKluft e045267
Fix no coverage engine warning by adding pcov as coverage option
RubenKluft c16f5f9
Update php version in test pipeline
RubenKluft a9421a8
Fix incorrect paths
RubenKluft 1c4ac0a
Fix incorrect paths
RubenKluft 72531f6
update editor config, gitattributes and phpcs to match company standa…
RubenKluft 7d4aeac
Merge remote-tracking branch 'skeleton/master' into init-repo
RubenKluft 3d7f3ce
update phpunit.dist.xml to be more verbose by default (#56)
RubenKluft 354baf3
Merge remote-tracking branch 'skeleton/master' into init-repo
RubenKluft 8915a60
Merge remote-tracking branch 'origin/master' into init-repo
RubenKluft a63674d
Merge remote-tracking branch 'origin/master' into init-repo
RubenKluft 9e20d2c
Lower SlevomatCodingStandard.Complexity.Cognitive to 6 for library
RubenKluft 2a92985
Remove .gitkeep
RubenKluft b096509
Apply editor config (#57)
RubenKluft 60edcb2
Merge remote-tracking branch 'skeleton/master' into init-repo
RubenKluft f2bb41e
Merge remote-tracking branch 'origin/master' into init-repo
RubenKluft 53c7497
Fix incorrect method name in readme
RubenKluft 3e554fd
Fix incorrect method name in readme
RubenKluft e9e9f61
Fix path in phpstan.neon
RubenKluft 8c28371
Allow phpunit 12
RubenKluft 002996d
Revert "Allow phpunit 12"
RubenKluft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| /.idea | ||
| /vendor | ||
| /composer.lock | ||
| /phpunit.xml | ||
| /.phpunit.result.cache | ||
| /.phpunit.cache | ||
| /composer.lock | ||
| /coverage.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,86 @@ | ||
| [](https://php.net/) | ||
| # Digitalrevolution IPP library | ||
|
|
||
| ## Installation | ||
|
|
||
| ```bash | ||
| composer require digitalrevolution/ipp | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| ### Initialize the library | ||
| ```php | ||
| $server = new IppServer(); | ||
| $server->setUri('https://cups.local'); | ||
| $server->setUserName('admin'); // optional | ||
| $server->setPassword('admin'); // optional | ||
|
|
||
| $ipp = new Ipp($server, new Psr18Client()); | ||
| ``` | ||
|
|
||
| ### Print a file | ||
| ```php | ||
| // define a printer | ||
| $printer = new IppPrinter(); | ||
| $printer->setHostname('my.printer'); | ||
|
|
||
| // print a file on the selected printer | ||
| $ippFile = new IppPrintFile(file_get_contents('/dir/file.ps'), FileTypeEnum::PS); | ||
| $ipp->print($printer, $ippFile); | ||
| ``` | ||
|
|
||
| ### Fetch job attributes | ||
| ```php | ||
| $printJob = $ipp->print($printer, $ippFile); | ||
| $updatedPrintJob = $ipp->getJobAttributes($printJob->getJobUri()); | ||
| ``` | ||
|
|
||
| ### Register a printer with cups | ||
| ```php | ||
| $printer = new IppPrinter(); | ||
| $printer->setHostname('my.printer'); | ||
| $printer->setDeviceUri('my.uri'); | ||
| $printer->setLocation('location'); | ||
|
|
||
| $ipp->createPrinter($printer); | ||
| ``` | ||
|
|
||
| ### Delete a printer | ||
| ```php | ||
| $printer = new IppPrinter(); | ||
| $printer->setHostname('my.printer'); | ||
|
|
||
| $ipp->deletePrinter($printer); | ||
| ``` | ||
|
|
||
| ### Contributing | ||
| See [contributing.md](./CONTRIBUTING.md) | ||
| Pull requests welcome for adding standard IPP Operations | ||
|
|
||
| ### Creating a custom IPP operation | ||
|
|
||
| This project is created to be easily extensible, adding a new IPP operation is as simple as making sure it has an identifier in IppOperationEnum | ||
| Then adding any Job, Printer or Operation Attributes as required by your standard. | ||
| Finally sending the request and parsing the response using the standard parser. | ||
| ```php | ||
| public function myOperation(): IppResponseInterface | ||
| $operation = new IppOperation(IppOperationEnum::OperationType); | ||
| $operation->addOperationAttribute(new IppAttribute(IppTypeEnum::Charset, 'attributes-charset', 'utf-8')); | ||
|
|
||
| $response = $this->client->sendRequest( | ||
| new Request( | ||
| 'POST', | ||
| $this->server->getUri(), | ||
| ['Content-Type' => 'application/ipp'], | ||
| (string)$operation | ||
| ) | ||
| ); | ||
|
|
||
| return $this->parser->getResponse($response->getBody()->getContents()); | ||
| } | ||
| ``` | ||
|
|
||
| ## About us | ||
|
|
||
| At 123inkt (Part of Digital Revolution B.V.), every day more than 50 development professionals are working on improving our internal ERP | ||
| At 123inkt (Part of Digital Revolution B.V.), every day more than 50 development professionals are working on improving our internal ERP | ||
| and our several shops. Do you want to join us? [We are looking for developers](https://www.werkenbij123inkt.nl/zoek-op-afdeling/it). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,73 @@ | ||
| { | ||
| "name": "digitalrevolution/skeleton", | ||
| "description": "Digital Revolution skeleton package", | ||
| "name": "digitalrevolution/ipp", | ||
| "description": "Digital Revolution IPP library", | ||
| "type": "library", | ||
| "license": "MIT", | ||
| "minimum-stability": "stable", | ||
| "config": { | ||
| "sort-packages": true, | ||
| "process-timeout": 0, | ||
| "allow-plugins": { | ||
| "phpstan/extension-installer": true | ||
| } | ||
| "phpstan/extension-installer": true, | ||
| "dealerdirect/phpcodesniffer-composer-installer": true, | ||
| "digitalrevolution/php-codesniffer-baseline": true | ||
| }, | ||
| "lock": false | ||
| }, | ||
| "require": { | ||
| "php": ">=8.1" | ||
| "php": "^8.3", | ||
| "nyholm/psr7": "^1.8", | ||
| "psr/http-client": "^1.0", | ||
| "psr/log": "^3.0", | ||
| "digitalrevolution/utils": "^1.0" | ||
| }, | ||
| "require-dev": { | ||
| "digitalrevolution/phpunit-file-coverage-inspection": "^v2.0.0", | ||
| "phpmd/phpmd": "^2.14", | ||
| "phpstan/extension-installer": "^1.3", | ||
| "phpstan/phpstan": "^2.0", | ||
| "phpstan/phpstan-phpunit": "^2.0", | ||
| "phpstan/phpstan-strict-rules": "^2.0", | ||
| "phpunit/phpunit": "^11.5 || ^12.0", | ||
| "digitalrevolution/accessorpair-constraint": "^v2.4.1", | ||
| "digitalrevolution/phpunit-file-coverage-inspection": "^3.0", | ||
| "digitalrevolution/php-codesniffer-baseline": "^1.1", | ||
| "phpmd/phpmd": "^2.12", | ||
| "phpstan/extension-installer": "^1.2", | ||
| "phpstan/phpstan": "^1.9.1", | ||
| "phpstan/phpstan-phpunit": "^1.2.2", | ||
| "phpunit/phpunit": "^11.5", | ||
| "roave/security-advisories": "dev-latest", | ||
| "squizlabs/php_codesniffer": "^3.7", | ||
| "slevomat/coding-standard": "^8.16" | ||
| }, | ||
| "scripts": { | ||
| "baseline": ["@baseline:phpstan", "@baseline:phpmd"], | ||
| "baseline": [ | ||
| "@baseline:phpstan", | ||
| "@baseline:phpmd" | ||
| ], | ||
| "baseline:phpstan": "phpstan --generate-baseline", | ||
| "baseline:phpmd": "phpmd src,tests xml phpmd.xml.dist --generate-baseline", | ||
| "check": ["@check:phpstan", "@check:phpmd", "@check:phpcs"], | ||
| "baseline:phpmd": "phpmd src,tests xml phpmd.xml --generate-baseline", | ||
| "check": [ | ||
| "@check:phpstan", | ||
| "@check:phpmd", | ||
| "@check:phpcs" | ||
| ], | ||
| "check:phpstan": "phpstan analyse", | ||
| "check:phpmd": "phpmd src,tests text phpmd.xml.dist --suffixes php", | ||
| "check:phpmd": "phpmd src,tests text phpmd.xml --suffixes php", | ||
| "check:phpcs": "phpcs src tests", | ||
| "fix": "@fix:phpcbf", | ||
| "fix:phpcbf": "phpcbf src tests", | ||
| "test": "phpunit", | ||
| "test:integration": "phpunit --testsuite integration", | ||
| "test:unit": "phpunit --testsuite unit" | ||
| "test": [ | ||
RubenKluft marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "@test:unit:coverage", | ||
| "@test:phpfci" | ||
| ], | ||
| "test:unit": "phpunit --testsuite unit", | ||
| "test:unit:coverage": "phpunit --testsuite unit --coverage-clover coverage.xml", | ||
| "test:phpfci": "phpfci inspect coverage.xml --exit-code-on-failure" | ||
RubenKluft marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "DR\\Ipp\\": "src/" | ||
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { | ||
| "DR\\Ipp\\Tests\\Unit\\": "tests/Unit/", | ||
| "DR\\Ipp\\Tests\\": "tests/" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpfci xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="vendor/digitalrevolution/phpunit-file-coverage-inspection/resources/phpfci.xsd" | ||
| min-coverage="100" | ||
| > | ||
| min-coverage="100"> | ||
| </phpfci> |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ parameters: | |
| treatPhpDocTypesAsCertain: false | ||
| paths: | ||
| - src | ||
| - tests | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "local>123inkt/.github:renovate-config" | ||
| ] | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "local>123inkt/.github:renovate-config" | ||
| ] | ||
| } |
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.