Fix str_getcsv notice. Escape parameter default will change#64
Merged
frankdekker merged 2 commits intomasterfrom Dec 29, 2025
Merged
Fix str_getcsv notice. Escape parameter default will change#64frankdekker merged 2 commits intomasterfrom
frankdekker merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a future PHP deprecation notice related to the str_getcsv function's escape parameter default value and enhances PHPUnit configuration for stricter testing standards.
- Explicitly sets the escape parameter in
str_getcsvto maintain current behavior and silence deprecation warnings - Updates PHPUnit configuration with stricter test execution settings and deprecation handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Rule/RuleParser.php | Explicitly sets the escape parameter for str_getcsv() to "\\" to future-proof against PHP default changes |
| phpunit.xml.dist | Adds stricter PHPUnit configuration options including failure flags, detail display settings, and Symfony deprecation helper configuration; removes bootstrap (auto-detected by PHPUnit 10+) and executionOrder attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bram123
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.