InConstraint should pass null instead of empty array to parent constructor#66
Merged
frankdekker merged 1 commit intomasterfrom Mar 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses a deprecation warning introduced in Symfony 7.4 by modifying how the InConstraint class initializes its parent Constraint class. The change updates the first argument passed to parent::__construct() from an empty array [] to null, which is the correct way to indicate that no options should be evaluated by the base Constraint class.
Changes:
- Updated
InConstraintconstructor to passnullinstead of empty array to parent constructor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bram123
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
User Deprecated: Since symfony/validator 7.4: Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor of DigitalRevolution\SymfonyValidationShorthand\Constraint\Type\InConstraint instead.