-
Notifications
You must be signed in to change notification settings - Fork 27
Vue3 Upgrade #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 Upgrade #181
Conversation
chore: update pages
marvin-roesch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice overall, thanks for putting in the effort to bring this code base into the modern world 😁
I only had three comments to leave, one concerning the actual functionality of the app and the other two regarding now-obsolete files.
Apart from that, the only thing I have to point out code-wise is that there are a few files (e.g. the scripts in bin/) which now have lines that are only whitespace, probably from a search & replace gone a little wrong. If these lines could be removed, that'd be great!
Thanks again for the great work!
|
@marvin-roesch , I have addressed the linting issue with 42a2f44, by adding a new linter warn, and running it through with Do we have an equally hard opinion on multiple empty lines? If yes, I'd suggest un-commenting the |
|
Had to change the github pages action due to failing dep download. Now following official Github Actions Recommendations, which suggest |
|
@marvin-roesch, seems like |
1. Core Infra (Vue Upgrade)
The entire Vue core and compiler stack was replaced.
2. Build System (Webpack → Vite)
Complete replacement of the build infrastructure.
3. Vue Ecosystem (Major Version Bumps)
Core-ish libraries updated to their Vue 3 compatible versions.
4. UI Libraries & Utilities
Components that had to be swapped or bumped.
5. Dev Dependencies & Maintenance
6. Minor Improvements
7. Results & Benchmarks
Comparison between the previous Webpack/Vue 2 build and the new Vite/Vue 3 build.
Build & Runtime Metrics
Lighthouse Performance
Dep Count
(If my count is right)
Left To Do